Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing #512

Open
JeppeKlitgaard opened this issue Oct 8, 2020 · 2 comments
Open

Typing #512

JeppeKlitgaard opened this issue Oct 8, 2020 · 2 comments
Milestone

Comments

@JeppeKlitgaard
Copy link
Contributor

Since aiocache only supports modern Python 3 versions, I was wondering if there would be an interesting in having the library be typed?

I wouldn't mind doing the work to get this done, but wanted to get feedback on whether this is something that the maintainers of aiocache would even want.

On that same note, how do people feel about dropping Python 3.5 support now that the release has officially reached end-of-life.

@argaen
Copy link
Member

argaen commented Oct 8, 2020

Hey @JeppeKlitgaard, I don't have anything against adding typing so go for it 👍. Same with dropping 3.5 support, been a while since wanted to do this plus adding support for 3.8 (and 3.9 now) but if you want to give it a try, please do :)

@Dreamsorcerer
Copy link
Member

Mypy has been configured on the repository, so if anyone wants to start contributing to this, please feel free to make a PR that adds some more annotations.

To work on it, start by uncommenting check_untyped_defs in .mypy.ini and fixing the errors that appear when running mypy.
If there are too many errors to start with, you can disable the option in sections of the code initially until it is manageable. e.g.

[mypy-tests.*]
check_untyped_defs = False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants