Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Redis 6 Support #859

Closed
seandstewart opened this issue Nov 28, 2020 · 4 comments
Closed

Redis 6 Support #859

seandstewart opened this issue Nov 28, 2020 · 4 comments
Labels
bug help wanted need investigation Need to look into described issue. resolved-via-latest This indicates this issue is either resolved or invalid as of the latest version.

Comments

@seandstewart
Copy link
Collaborator

We seem to have a few failing tests with the introduction of Redis 6.0 into the pipeline. Unfortunately the current output is not very helpful:

https://github.com/aio-libs/aioredis/runs/1468097976?check_suite_focus=true#step:11:5000

@seandstewart seandstewart added bug help wanted need investigation Need to look into described issue. labels Nov 28, 2020
@seandstewart seandstewart added this to To do in Resuscitation via automation Nov 28, 2020
@Andrew-Chen-Wang
Copy link
Collaborator

Just to get this fixed quickly, some things to take note:

  • test_master__auth: add username as a keyword parameter next to password in conftest.py's start_server fixture. We may just need two different tests to make sure username and password are both checked.
  • test_auth: the message is just different for Redis 6.0. You may want to test both the message for password and the one for username like aforementioned.
  • test_failover_command : not entirely sure what's wrong
  • test_client_list : Redis 6.2 added laddr. I'm not able to see that for myself, strangely enough... Set to MOCK.Any
  • test_client_list__unixsocket: again, I couldn't see it, so I'm not sure what part of Redis instance could show this...
  • test_command_info: it's just a Redis 6.0 addition

@seandstewart
Copy link
Collaborator Author

I'm going to remove Redis 6 from the pipeline until we've patched this so we can have a green build again on master.

@asvetlov
Copy link
Contributor

I'm going to remove Redis 6 from the pipeline until we've patched this so we can have a green build again on master.

The best you can do now

@seandstewart
Copy link
Collaborator Author

This issue should be resolved as of #891.

Resuscitation automation moved this from To do to Done Mar 19, 2021
@seandstewart seandstewart added the resolved-via-latest This indicates this issue is either resolved or invalid as of the latest version. label Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug help wanted need investigation Need to look into described issue. resolved-via-latest This indicates this issue is either resolved or invalid as of the latest version.
Projects
No open projects
Development

No branches or pull requests

3 participants