Frequent connection errors #1281
Comments
nothing conn wise should have changed. Unfortunately, I'm a little busy with midterms and migrating aioredis to Redis-py with RedisLabs. I will come back to this once things have settled over there. Sorry! |
Seems like there were a few changes around reading and parsing responses, no idea if that could be the issue, but it's a place to start. |
Thanks, I've found it: v2.0.0...v2.0.1#diff-6d3e65633ef76c2cc5e938736e2b2190317629f27f99f24384f4f1def6bd151dR10 Not sure if you want to consider reverting that change or not, but the conftest has some retry logic after catching |
Great - thanks for isolating the issue. This is one of those chicken-egg scenarios where this exception is actually mimicking redis-py's (questionable) implementation. An additional option would be to have our connection error inherent from the builtin, which feels sensible to me. |
That's what it did, the changelog shows the inheritance was removed. Appears to be this PR: #1129 I'll leave you to decide if that change should be reverted or not. |
We are now getting frequent connection errors in the CI for aiohttp-session for 2.0.1. Doesn't seem to be a problem with 2.0.0.
Any ideas on what is happening there would be great:
aio-libs/aiohttp-session#652
The text was updated successfully, but these errors were encountered: