Consolidate gpu environment logic in buildenv #32
+3
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
env.daint.sh
Outdated
| @@ -12,6 +12,7 @@ module load Boost/1.70.0-CrayGNU-20.11-python3 | |||
| module load cudatoolkit/11.2.0_3.39-2.1__gf93aa1c | |||
| module load graphviz/2.44.0 | |||
| module load /project/s1053/install/modulefiles/gcloud/303.0.0 | |||
| module load nvidia-nsight-systems/2021.1.1.66-6c5c5cb | |||
There was a problem hiding this comment.
This isn't required to run GPU and shouldn't be loaded by default
FlorianDeconinck
approved these changes
Dec 17, 2021
mcgibbon
added a commit
to ai2cm/pace
that referenced
this pull request
Dec 17, 2021
## Purpose run_command currently takes a G2G argument we have hard-coded to always be false. This PR removes that argument, and moves several environment variables from pace into buildenv. Depends on ai2cm/buildenv#32. ## Infrastructure changes: - G2G is removed as an argument for run_command - DOCKER_BUILDKIT=1 is set in buildenv, not pace - PYTHONOPTIMIZE=TRUE is set in run_on_daint.sh, not in the slurm script - updated pace-util jenkins.sh to match buildenv run_command api
rheacangeo
reviewed
Dec 19, 2021
| export MPICH_G2G_PIPELINE=256 | ||
| export MPICH_NEMESIS_ASYNC_PROGRESS=1 | ||
| export MPICH_MAX_THREAD_SAFETY=multiple | ||
| export DOCKER_BUILDKIT=1 |
There was a problem hiding this comment.
this doesn't make sense in env.daint.sh, there is no docker there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infrastructure changes:
Linked to ai2cm/pace#76