Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yarn 2 support #156

Merged
merged 2 commits into from Jan 31, 2020
Merged

Yarn 2 support #156

merged 2 commits into from Jan 31, 2020

Conversation

pustovalov
Copy link
Contributor

Related to #154

@ai
Copy link
Owner

ai commented Jan 30, 2020

CI fails because packages/size-limit/create-help.js:89 line was not covered with tests

@ai ai merged commit ad7dbd3 into ai:master Jan 31, 2020
@ai
Copy link
Owner

ai commented Jan 31, 2020

Do we need a major release? Or it will just print warning?

@pustovalov
Copy link
Contributor Author

It will print a warning, if user doesn’t have a size-limit in dev dependencies
https://github.com/ai/size-limit/pull/156/files#diff-ba32842adaed10794b6c66a24aaea6a4R120

@pustovalov
Copy link
Contributor Author

Do we still need this dependency?
https://github.com/ai/size-limit/blob/master/packages/file/package.json#L21

@ai
Copy link
Owner

ai commented Jan 31, 2020

Released at 3.0.1.

Yeap, seems like we forget to move size-limit from dependencies to peerDependencies. Can you send another PR?

@ai
Copy link
Owner

ai commented Jan 31, 2020

I will fix dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pustovalov @ai