Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax pycryptodome requirements #13

Closed
cveilleux opened this issue Apr 24, 2018 · 2 comments
Closed

Relax pycryptodome requirements #13

cveilleux opened this issue Apr 24, 2018 · 2 comments

Comments

@cveilleux
Copy link

setup.py currently requires:

pycryptodome==3.4.7

see: https://github.com/ahknight/httpsig/blob/master/setup.py#L40

install_requires should not be used to pin dependencies to exact version. See: https://packaging.python.org/discussions/install-requires-vs-requirements/

It is not considered best practice to use install_requires to pin dependencies to specific versions, or to specify sub-dependencies (i.e. dependencies of your dependencies). This is overly-restrictive, and prevents the user from gaining the benefit of dependency upgrades.

Unless there is a good reason which I am not aware of, something like:

install_requires=['pycryptodome>=3,<4', 'six']

should accept any pycryptodome version 3.x.x

@ericbuckley
Copy link

Is there any reason PR #14 can't be merged? Version pycryptodome==3.4.7 has a known vulnerability. https://nvd.nist.gov/vuln/detail/CVE-2018-15560

@smcoll
Copy link

smcoll commented Oct 15, 2018

@ahknight this would resolve a security vulnerability for any project requiring this package: see Legrandin/pycryptodome#198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants