Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #480 #504

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes #480 #504

wants to merge 2 commits into from

Conversation

DanielHudson
Copy link
Contributor

No description provided.

@aheckmann
Copy link
Owner

a) The colour typo is definitely a bug. Thanks for the fix.
b) Seems the quotes issue is to support hex values. Somehow the tests pass here. Might be good to update the tests to show named colors working as well.

@DanielHudson
Copy link
Contributor Author

b) I believe there is also a difference between how Graphicsmagick and ImageMagick handle these color values, so a little more investigation is required.

@aheckmann
Copy link
Owner

I pulled in the highlightColor fix into 1.22.0.

@snyk-bot snyk-bot mentioned this pull request Sep 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DanielHudson @aheckmann