Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make typeguard work on python3.9 #150

Merged
merged 5 commits into from Oct 8, 2020
Merged

Conversation

deathowl
Copy link
Contributor

@deathowl deathowl commented Oct 7, 2020

Add python 3.9 to tox.ini
make tests pass for 3.9 as well as other supported python versions
fix #149

@coveralls
Copy link

coveralls commented Oct 7, 2020

Coverage Status

Coverage increased (+0.2%) to 88.808% when pulling 74c17c0 on deathowl:master into 55fbcb5 on agronholm:master.

@deathowl
Copy link
Contributor Author

deathowl commented Oct 7, 2020

sorry for the python3.9-dev in the travis.yml can be replaced with non-dev 3.9 once travis makes it available

Copy link
Owner

@agronholm agronholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly code style changes requested. Seems good otherwise.

tests/test_typeguard.py Outdated Show resolved Hide resolved
typeguard/__init__.py Show resolved Hide resolved
typeguard/__init__.py Outdated Show resolved Hide resolved
typeguard/__init__.py Outdated Show resolved Hide resolved
typeguard/__init__.py Outdated Show resolved Hide resolved
typeguard/__init__.py Outdated Show resolved Hide resolved
@deathowl
Copy link
Contributor Author

deathowl commented Oct 8, 2020

@agronholm addressed your requests.

@agronholm
Copy link
Owner

I screwed up the build. I'll fix that before I merge.

@agronholm
Copy link
Owner

Thanks!

@deathowl
Copy link
Contributor Author

deathowl commented Oct 8, 2020

btw what is your opinion on using black to automate code formatting in the future?

@agronholm
Copy link
Owner

Over my rotting corpse.

@leycec
Copy link

leycec commented Oct 12, 2020

⮤ This is the only valid response to that question.

@shadchin
Copy link

Can you upload to PyPI release with support Python 3.9?

@agronholm
Copy link
Owner

I tried...but it seems some changes on Travis have broken my workflow. It ended uploading typeguard-0.0.0 to PyPI :(

@agronholm
Copy link
Owner

Scratch that, it was the continued modernization of setup.py.

@agronholm
Copy link
Owner

Done, it's now on PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make typeguard work on python 3.9
5 participants