Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use __new__() only for initialization #52

Merged
merged 4 commits into from Dec 22, 2022
Merged

Use __new__() only for initialization #52

merged 4 commits into from Dec 22, 2022

Conversation

agronholm
Copy link
Owner

Fixes #46.

@coveralls
Copy link

coveralls commented Dec 10, 2022

Copy link
Contributor

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this locally, but from checking against CPython it looks good to me 👍

@agronholm
Copy link
Owner Author

Thanks! I'll cut a release later unless @KevinMGranger has objections.

@agronholm agronholm merged commit a359629 into main Dec 22, 2022
@agronholm agronholm deleted the use-new-only branch December 22, 2022 12:58
@agronholm
Copy link
Owner Author

I initially meant to make this into a major release but on further inspection it looks like it might not need a major bump after all. Trio at least passes its test suite against this new version without any changes, and that's the most demanding downstream project I know of, so I'll make a minor release instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialization behavior differs from 3.11 due to __init__
3 participants