Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config doesn't work #10

Open
nemergut opened this issue Jun 20, 2023 · 5 comments
Open

Config doesn't work #10

nemergut opened this issue Jun 20, 2023 · 5 comments

Comments

@nemergut
Copy link

Action ignore any changes from pint.json in root directory.

@aglipanci
Copy link
Owner

@nemergut can you illustrate the issue by creating a PR in the https://github.com/aglipanci/laravel-pint-action-demo?

@schaeferalex
Copy link

Same issue here pint.json in root directory being ignored. Specifying it via configPath: "pint.json" also doesn't help.

@aglipanci
Copy link
Owner

@nemergut @schaeferalex It works just fine on my end. You have have a look at the three actions run here: https://github.com/aglipanci/laravel-pint-action-demo/actions

I have edited the pint.json config and the errors are skipped during each run.

If there is a specific case I need you to create a PR with your configs on the demo repository so I can investigate more.

@deligoez
Copy link

also same issue here, my config looks like this:

      - name: Fix PHP code style issues
        uses: aglipanci/laravel-pint-action@2.3.0
        with:
          preset: laravel
          configPath: "vendor/phonyland/dev-tools/src/pint.json"

and may be i found the cause:

CleanShot 2023-08-23 at 01 20 37

locally i have this composer command, so it is with an equal sign (--config=)

"pint": "vendor/bin/pint --config=vendor/phonyland/dev-tools/src/pint.json",

@aglipanci
Copy link
Owner

@deligoez according to the Laravel docs the equal sign it's not required. Would you mind replicating the same behaviour on the demo repository here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants