Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow opting out #69

Closed
tkellen opened this issue Jun 29, 2015 · 8 comments
Closed

allow opting out #69

tkellen opened this issue Jun 29, 2015 · 8 comments
Assignees

Comments

@tkellen
Copy link

tkellen commented Jun 29, 2015

It would be nice for highly technical users to be able to opt out of using this, and for hostsupdater to provide a message stating what configuration must be added if a user opts out.

Would you accept a PR for this behavior, or consider implementing it yourself?

/cc @tbranyen @jugglinmike

@cgsmith
Copy link
Collaborator

cgsmith commented Nov 3, 2015

I believe #62 may address this. If so you can test it locally or submit a PR.

@tkellen
Copy link
Author

tkellen commented Nov 3, 2015

Hey @cgsmith! This doesn't quite do the trick. Also, this project seems abandoned so I'm not holding out hope it will be merged. Hey, @Cogitatio would you be willing to transfer ownership of this repo to me? I'd be happy to maintain it since you clearly don't have the time.

@cgsmith
Copy link
Collaborator

cgsmith commented Nov 3, 2015

Hi @tkellen, @Cogitatio added me as a contributor for maintaining the repository. I'd be happy to pull in any PR that you attach for the behavior. Let me know your thoughts.

@cgsmith cgsmith self-assigned this Nov 3, 2015
@tkellen
Copy link
Author

tkellen commented Nov 3, 2015

That's great news @cgsmith! I'll see what I can come up with soon.

@cgsmith
Copy link
Collaborator

cgsmith commented Nov 3, 2015

Perfect 👍

I would gladly implement a solution as well if the specs of what you'd like are defined well. This next release will focus on fixing the bugs.

@cgsmith
Copy link
Collaborator

cgsmith commented Jan 15, 2016

Releasing in 1.0.2

@cgsmith cgsmith closed this as completed Jan 15, 2016
@tkellen
Copy link
Author

tkellen commented Jan 15, 2016

cc @tafsiri, it's here!

@tkellen
Copy link
Author

tkellen commented Jan 15, 2016

thanks @cgsmith !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants