Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line break not inserted before first host — leads to broken lines #37

Closed
markjaquith opened this issue Mar 24, 2014 · 3 comments
Closed
Labels
Milestone

Comments

@markjaquith
Copy link
Contributor

MAMP Pro seems to insert its rules at the end of /etc/hosts without a trailing line break. vagrant-hostsupdater then adds its rules after without a prepended line break. Thus, two rules get put on one line, and the vagrant-hostsupdater line does not work. I have to manually go in and fix it from time to time.

I would suggest that vagrant-hostsupdater always include a prepended line break.

@andrewnoruk
Copy link

My team has been having this problem as well. Some use MAMP for certain projects and Vagrant for others, and we frequently will need to go in and manually append the new line to the hosts file.

@tkdb
Copy link
Contributor

tkdb commented May 8, 2014

+1 to always have a line break, can't hurt.

tkdb added a commit to tkdb/vagrant-hostsupdater that referenced this issue May 8, 2014
@cgsmith cgsmith added the bug label Nov 4, 2015
@cgsmith cgsmith added this to the 0.12 milestone Nov 4, 2015
@cgsmith
Copy link
Collaborator

cgsmith commented Nov 8, 2015

Fixed in 1.0.0

@cgsmith cgsmith closed this as completed Nov 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants