Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for VMs without private/public networking #23

Merged
merged 1 commit into from
Mar 30, 2018
Merged

Add support for VMs without private/public networking #23

merged 1 commit into from
Mar 30, 2018

Conversation

radeksimko
Copy link
Contributor

When VM does not have any explicit private or public networking defined in Vagrantfile, all services on any ports are obviously available on 127.0.0.1 by default, which is also IP used when SSH'ing to that VM.

Users might not want to setup any public/private IPs just because they want set up hostnames.

In general - is there any meaningful reason to not support this?

@amferraz
Copy link

👍

@lechup
Copy link

lechup commented Nov 6, 2013

+1, for me also public didn't work (as stated in docs, you need static private IP). I saw that line after browsing this issue, so maybe it would be nice idea to at least bold this part in docs?

@edword
Copy link

edword commented Jan 30, 2014

👍

@cgsmith cgsmith added this to the 1.0.2 milestone Dec 8, 2015
@cgsmith cgsmith self-assigned this Dec 8, 2015
@lwh
Copy link

lwh commented Dec 24, 2015

Could it be conditional i.e. disable-able by config in case you don't want it to do 127.0.0.1 ? Something like this but also skip it if a var like mentioned here #91 is set to no?

@radeksimko
Copy link
Contributor Author

This went off my radar somehow, so the branch had some conflicts, but I just rebased it.

The idea in #91 isn't bad, but I would personally expect this to work out of the box (i.e. w/out any specific DSL option). Is there any harm that this "out-of-the-box behaviour" may cause?

@lwh
Copy link

lwh commented Dec 24, 2015

I think it's good as a default , even if you had other networks. I would only want it disable if I set it like in #91 , i.e. if !localhostconfig = false then add 127.0.0.1

@isaacfife
Copy link

This would help me out since I have to use localhost due to my workplace VPN making non-localhost vagrant networks not work. What needs to happen to get this merged?

@cgsmith cgsmith merged commit 1db35fe into agiledivider:master Mar 30, 2018
@cgsmith
Copy link
Collaborator

cgsmith commented Mar 30, 2018

Merged.

@radeksimko radeksimko deleted the loopback-entries branch April 2, 2018 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants