Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove_on_suspend should default to true #19

Closed
markjaquith opened this issue Jun 29, 2013 · 4 comments
Closed

remove_on_suspend should default to true #19

markjaquith opened this issue Jun 29, 2013 · 4 comments
Labels
enhancement
Milestone
0.12

Comments

@markjaquith
Copy link
Contributor

Regarding #4, I think having remove_on_suspend default to false is very odd.

Why would you want your hosts entries to persist if your VM is not available? They're not of any use. And if it's a real domain you're resolving, it can actually lead to confusion. The entries relate to the VM. If the VM isn't running, the entries shouldn't be there.
markjaquith added a commit to markjaquith/vagrant-hostsupdater that referenced this issue Jun 29, 2013
@markjaquith
Makes remove_on_suspend default to true. fixes agiledivider#19
55daf5b
markjaquith added a commit to markjaquith/vagrant-hostsupdater that referenced this issue Jun 29, 2013
@markjaquith
Makes remove_on_suspend default to true. fixes agiledivider#19
de6f6f9
markjaquith added a commit to markjaquith/vagrant-hostsupdater that referenced this issue Jun 29, 2013
@markjaquith
Makes remove_on_suspend default to true. fixes agiledivider#19
7d7cc8a
@markjaquith markjaquith mentioned this issue Jun 29, 2013
Closed
@tbal
Copy link

tbal commented Aug 20, 2014

+1

2 similar comments
@cehwitham
Copy link

+1

@johnstonian
Copy link

+1

@cgsmith cgsmith added this to the 0.12 milestone Nov 4, 2015
@cgsmith
Copy link
Collaborator

cgsmith commented Nov 8, 2015

Fixed in 1.0.0

@cgsmith cgsmith closed this as completed Nov 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.12
Development

Successfully merging a pull request may close this issue.

Make remove_on_suspend default to true markjaquith/vagrant-hostsupdater
5 participants
@markjaquith @cgsmith @cehwitham @tbal @johnstonian