From b1dc1a348153598738c3325854b62cdd6fdf78f2 Mon Sep 17 00:00:00 2001 From: Mayur Kale Date: Mon, 5 Aug 2019 09:42:36 -0700 Subject: [PATCH] fix: minor fix (#153) * fix: minor fix * fix: remove _ prefix from params --- packages/opentelemetry-core/src/trace/TracerDelegate.ts | 2 +- packages/opentelemetry-core/test/trace/TracerDelegate.test.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/opentelemetry-core/src/trace/TracerDelegate.ts b/packages/opentelemetry-core/src/trace/TracerDelegate.ts index 2c98245a2..97fe214fe 100644 --- a/packages/opentelemetry-core/src/trace/TracerDelegate.ts +++ b/packages/opentelemetry-core/src/trace/TracerDelegate.ts @@ -55,7 +55,7 @@ export class TracerDelegate implements types.Tracer { ); } - startSpan(name: string, options?: types.SpanOptions | undefined): types.Span { + startSpan(name: string, options?: types.SpanOptions): types.Span { return this._currentTracer.startSpan.apply( this._currentTracer, // tslint:disable-next-line:no-any diff --git a/packages/opentelemetry-core/test/trace/TracerDelegate.test.ts b/packages/opentelemetry-core/test/trace/TracerDelegate.test.ts index 0c656ebed..c6186a9e5 100644 --- a/packages/opentelemetry-core/test/trace/TracerDelegate.test.ts +++ b/packages/opentelemetry-core/test/trace/TracerDelegate.test.ts @@ -35,7 +35,7 @@ describe('TracerDelegate', () => { traceOptions: TraceOptions.UNSAMPLED, }; - describe('#constructor(...)', () => { + describe('constructor', () => { it('should not crash with default constructor', () => { functions.forEach(fn => { const tracer = new TracerDelegate(); @@ -66,7 +66,7 @@ describe('TracerDelegate', () => { assert.deepStrictEqual(dummyTracer.spyCounter, 1); }); - describe('#start/stop()', () => { + describe('.start/stop()', () => { it('should use the fallback tracer when stop is called', () => { const dummyTracerUser = new DummyTracer(); const dummyTracerFallback = new DummyTracer();