Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commit helper (commitzen) #7

Closed
cgaube opened this issue Dec 31, 2021 · 2 comments
Closed

Add commit helper (commitzen) #7

cgaube opened this issue Dec 31, 2021 · 2 comments
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
Kanban Board

Comments

@cgaube
Copy link
Contributor

cgaube commented Dec 31, 2021

add dependency --dev to https://github.com/commitizen/cz-cli when they have fixed their issue with security

commitizen/cz-cli#874
@cgaube cgaube added the enhancement New feature or request label Dec 31, 2021
@cgaube cgaube added this to To do in Kanban Board Dec 31, 2021
@cgaube cgaube moved this from To do to In progress in Kanban Board Jan 25, 2022
cgaube added a commit that referenced this issue Jan 25, 2022
@cgaube
chore: add commitzend commit helper command
5ffa445 
Also updated mocha to newer version

#7
@cgaube cgaube mentioned this issue Jan 25, 2022
Closed
@cgaube cgaube linked a pull request Jan 25, 2022 that will close this issue
chore: add commitzend commit helper command #11
Closed
@cgaube
Copy link
Contributor Author

cgaube commented Feb 10, 2022

Workaround for now is to install the dependency globally (on each dev computer) so that it does not appear in the yarn.lock file

@cgaube cgaube moved this from In progress to To do in Kanban Board Feb 17, 2022
@cgaube
Copy link
Contributor Author

cgaube commented Feb 18, 2022

I am going to close this PR
commitizen seem to take their sweet time updating their repo / creating new release even if the fix has been merged

Instead of adding commitizen to this repo dependency we will just advice people to install it globally instead, if they want
most developers wont use this helper anyway when committing as using vim or other editor is much faster.

@cgaube cgaube closed this as completed Feb 18, 2022
@cgaube cgaube added the wontfix This will not be worked on label Feb 18, 2022
@cgaube cgaube moved this from To do to Done in Kanban Board Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
Kanban Board
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add commitzend commit helper command aftdev/dev-env-manager
1 participant
@cgaube