Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement GetNameEntryByNameHash #3669

Closed
davidyuk opened this issue Jun 24, 2021 · 1 comment · Fixed by #4348
Closed

Implement GetNameEntryByNameHash #3669

davidyuk opened this issue Jun 24, 2021 · 1 comment · Fixed by #4348

Comments

@davidyuk
Copy link
Member

I was going to move name validation to the step of validation of the whole transaction in JS-SDK but realized that I can't get name entry by name hash (the name is already hashed at that step). This is already implemented in middleware, but JS-SDK currently is not aware of the middleware, also resolving name entry by name hash shouldn't be an expensive operation for node because it has to do it while transaction execution.
@davidyuk davidyuk mentioned this issue Jun 24, 2021
Merged
@velzevur velzevur self-assigned this Sep 21, 2021
@davidyuk davidyuk mentioned this issue Dec 8, 2023
Merged
@davidyuk
Copy link
Member Author

davidyuk commented May 4, 2024

similar issue: #4128

One more use case: on the wallet side we show details of a name delegation to contract. In that case also have only name hash, but we want to show the name in a human-readable way.

@hanssv hanssv mentioned this issue May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add GetNameEntryByNameHash to HTTP (v3) API aeternity/aeternity
2 participants
@velzevur @davidyuk