Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to retrieve whole contract state of the GA contract, more improvement suggestions #4083

Open
loxs opened this issue Feb 4, 2023 · 6 comments · May be fixed by #4116
Open

Add ability to retrieve whole contract state of the GA contract, more improvement suggestions #4083

loxs opened this issue Feb 4, 2023 · 6 comments · May be fixed by #4116
Assignees
@velzevur
Labels
area/api Issues or PRs related to the public API

Comments

@loxs
Copy link
Contributor

loxs commented Feb 4, 2023 •
edited

aeternity/test/contracts/ga_main_w_temporary.aes

Line 19 in a3df5ba

record state =

As agreed in chat, please add the ability to retrieve whole contract state. But in particular the important bit is that the contract currently does not allow for retrieval of the 'master'

Other minor things that can be considered:

  • Consider changing the validator term in the whole contract to delegate as it better describes what's going on (Hans agreed to that)
  • Consider ability to change the master (transfer the GA to another master after it has been upgraded once)
  • Consider changing both the names of the file and the contract (inside the file) to something more suitable.
@loxs
Copy link
Contributor Author

loxs commented Feb 4, 2023 •
edited

@hanssv for awareness
@rumyanar for awareness

@hanssv
Copy link
Member

hanssv commented Feb 4, 2023

This is a contract that tests a concept not sure why the naming has any relevance - but it is open source, so feel free to make a PR 👍

@loxs
Copy link
Contributor Author

loxs commented Feb 4, 2023

Soon it will stop testing and will start being used

@velzevur
Copy link
Member

velzevur commented Feb 6, 2023

@loxs please keep issues self contained and independent. An external endpoint for fetching contract's state has nothing to do with contract features and should not be mixed together.

@velzevur velzevur added area/api Issues or PRs related to the public API and removed area/generalized_accounts labels Feb 6, 2023
@dincho
Copy link
Member

dincho commented Feb 6, 2023

@loxs please keep issues self contained and independent. An external endpoint for fetching contract's state has nothing to do with contract features and should not be mixed together.

isn't this about the contract itself API ? i.e. adding get_state function?

@loxs
Copy link
Contributor Author

loxs commented Feb 6, 2023

@velzevur I wan to talk to you again before I create more issues, as I am not sure what is the right direction we should go regarding this. In the meantime the call to retrieve the state is probably a good idea regardless

@velzevur velzevur linked a pull request Mar 21, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@velzevur velzevur

Labels
area/api Issues or PRs related to the public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revisit GA contract ga_main_w_temporary.aes aeternity/aeternity
4 participants
@hanssv @loxs @dincho @velzevur