Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit hooks setup is failing. #94

Closed
zoj613 opened this issue May 3, 2023 · 1 comment
Closed

pre-commit hooks setup is failing. #94

zoj613 opened this issue May 3, 2023 · 1 comment
Labels
CI Relates to continuous integration good first issue Good for newcomers

Comments

@zoj613
Copy link
Member

zoj613 commented May 3, 2023

Description of your problem or feature request

Setting up pre-commit hooks fails due to a bug in isort explained here: PyCQA/isort#2083
Please provide a minimal, self-contained, and reproducible example.

pre-commit install-hooks

Please provide the full traceback of any errors.

[INFO] Installing environment for https://github.com/pycqa/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('/home/zoj/.cache/pre-commit/repopytli6no/py_env-python3/bin/python', '-mpip', 'install', '.')
return code: 1
stdout:
    Processing /home/zoj/.cache/pre-commit/repopytli6no
      Installing build dependencies: started
      Installing build dependencies: finished with status 'done'
      Getting requirements to build wheel: started
      Getting requirements to build wheel: finished with status 'done'
      Preparing metadata (pyproject.toml): started
      Preparing metadata (pyproject.toml): finished with status 'error'
stderr:
      error: subprocess-exited-with-error

      × Preparing metadata (pyproject.toml) did not run successfully.
      │ exit code: 1
      ╰─> [17 lines of output]
          Traceback (most recent call last):
            File "/home/zoj/.cache/pre-commit/repopytli6no/py_env-python3/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
              main()
            File "/home/zoj/.cache/pre-commit/repopytli6no/py_env-python3/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
              json_out['return_val'] = hook(**hook_input['kwargs'])
                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
            File "/home/zoj/.cache/pre-commit/repopytli6no/py_env-python3/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 149, in prepare_metadata_for_build_wheel
              return hook(metadata_directory, config_settings)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
            File "/tmp/pip-build-env-218ucduw/overlay/lib/python3.11/site-packages/poetry/core/masonry/api.py", line 40, in prepare_metadata_for_build_wheel
              poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
            File "/tmp/pip-build-env-218ucduw/overlay/lib/python3.11/site-packages/poetry/core/factory.py", line 57, in create_poetry
              raise RuntimeError("The Poetry configuration is invalid:\n" + message)
          RuntimeError: The Poetry configuration is invalid:
            - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

          [end of output]

      note: This error originates from a subprocess, and is likely not a problem with pip.
    error: metadata-generation-failed

    × Encountered error while generating package metadata.
    ╰─> See above for output.

    note: This is an issue with the package mentioned above, not pip.
    hint: See above for details.
Check the log at /home/zoj/.cache/pre-commit/pre-commit.log

Please provide any additional information below.
We need to update the isort version in the precommit config to 5.12.0

Versions and main components

  • Aesara version: 2.8.12
  • Aesara config (python -c "import aesara; print(aesara.config)")
  • Python version: 3.11
  • Operating system: Linux
  • How did you install Aesara: conda
@zoj613 zoj613 added good first issue Good for newcomers CI Relates to continuous integration labels May 3, 2023
@zoj613
Copy link
Member Author

zoj613 commented May 8, 2023

closed by #98

@zoj613 zoj613 closed this as completed May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Relates to continuous integration good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant