Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Console error that cannot be suspended #329

Open
wtrocki opened this issue Apr 16, 2019 · 2 comments
Open

Console error that cannot be suspended #329

wtrocki opened this issue Apr 16, 2019 · 2 comments

Comments

@wtrocki
Copy link
Contributor

wtrocki commented Apr 16, 2019

Bug Report

When starting SDK in any app following error appears a couple of times:

vendor.js:21535 Error when sending metrics {"stack":"Error: Metrics server configuration is missing. Metrics will be disabled.\n    at MetricsService.

there is no way to suspend it. Not having metrics enabled is not an error so we might remove this to not obfuscate logs.

ping @austincunningham

@austincunningham
Copy link
Member

austincunningham commented Apr 17, 2019

introduced here

console.warn("Metrics configuration is missing." +

no that's a different error.

its here

const err = new Error("Metrics server configuration is missing. Metrics will be disabled.");

That may be why it appears a couple of times. :)

@wtrocki
Copy link
Contributor Author

wtrocki commented Apr 17, 2019

Actually, it is being printed 3 times because of code here:

const err = new Error("Metrics server configuration is missing. Metrics will be disabled.");
console.warn(err);
return Promise.reject(err);

This is caused by d5c0497

We always send metrics now (even when there is no config)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants