Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There are some problems between nhooyr/websocket package and Binance WebSocket API. #321

Closed
XanderShum opened this issue Nov 9, 2021 · 8 comments
Closed

There are some problems between nhooyr/websocket package and Binance WebSocket API. #321

XanderShum opened this issue Nov 9, 2021 · 8 comments

Comments

@XanderShum
Copy link
Contributor

I ran into the same problem as follows:
nhooyr/websocket#315

I think this is a problem we need to pay attention to. Obviously there are some problems with nhooyr/websocket.
@XanderShum
Copy link
Contributor Author

@adshao

@adshao
Copy link
Owner

adshao commented Nov 10, 2021

I ran into the same problem as follows: nhooyr/websocket#315

I think this is a problem we need to pay attention to. Obviously there are some problems with nhooyr/websocket.

Thanks @XanderShum , I'll try to reproduce it.

@adshao
Copy link
Owner

adshao commented Dec 16, 2021

@XanderShum Hard to reproduce, is there any suggestion for this issue? I found https://github.com/nhooyr/websocket is not actively maintained now, should we change to use the dev branch of nhooyr/websocket, or revert the pr #290 ?

@ArminEbrahimi
Copy link

@adshao @XanderShum Would you please revert the pr #290 ?

@XanderShum
Copy link
Contributor Author

@adshao My current solution is to use the dev branch of nhooyr/websocket, but it's not perfect.

@XanderShum XanderShum reopened this Dec 18, 2021
@ArminEbrahimi
Copy link

@adshao @XanderShum Would you please revert the pr #290 ?

Any Updaye? @adshao #BlockingIssue

adshao added a commit that referenced this issue Mar 15, 2022
@adshao
Revert nhooyr.io/websocket
55c23a3 
due to issue: #321,
and nhooyr.io/websocket is not active for maintain.

revert pr #290.

Signed-off-by: adshao <tjusgj@gmail.com>
@adshao adshao mentioned this issue Mar 15, 2022
Merged
@adshao
Copy link
Owner

adshao commented Mar 15, 2022

@adshao @XanderShum Would you please revert the pr #290 ?

Any Updaye? @adshao #BlockingIssue

I'm reverting #290 in #357

adshao added a commit that referenced this issue Mar 15, 2022
@adshao
Revert nhooyr.io/websocket (#357)
ccf8ecf 
due to issue: #321,
and nhooyr.io/websocket is not active for maintain.

revert pr #290.

Signed-off-by: adshao <tjusgj@gmail.com>
@adshao
Copy link
Owner

adshao commented Mar 15, 2022

@ArminEbrahimi @XanderShum nhooyr.io/websocket is reverted to github.com/gorilla/websocket, let me know if there is any problems, thanks.

@adshao adshao closed this as completed Mar 15, 2022
softdev87 added a commit to softdev87/go-binance that referenced this issue Sep 8, 2022
@softdev87
Revert nhooyr.io/websocket (#357)
77357fe 
due to issue: adshao/go-binance#321,
and nhooyr.io/websocket is not active for maintain.

revert pr #290.

Signed-off-by: adshao <tjusgj@gmail.com>
XCr-9 added a commit to XCr-9/binance that referenced this issue Jan 9, 2024
@XCr-9
Revert nhooyr.io/websocket (#357)
2a89b8b 
due to issue: adshao/go-binance#321,
and nhooyr.io/websocket is not active for maintain.

revert pr #290.

Signed-off-by: adshao <tjusgj@gmail.com>
stormrageqb pushed a commit to stormrageqb/binance that referenced this issue Feb 12, 2024
@next-generation-X
Revert nhooyr.io/websocket (#357)
464b8a0 
due to issue: adshao/go-binance#321,
and nhooyr.io/websocket is not active for maintain.

revert pr #290.

Signed-off-by: adshao <tjusgj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adshao @ArminEbrahimi @XanderShum