Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace http methods to constants #317

Merged
merged 1 commit into from Oct 7, 2021
Merged

Replace http methods to constants #317

merged 1 commit into from Oct 7, 2021

Conversation

shoman4eg
Copy link
Contributor

Replace all http methods from string to http constants
Replace all http status codes to contants

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #317 (015a18c) into master (1c85553) will not change coverage.
The diff coverage is 95.45%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #317   +/-   ##
=======================================
  Coverage   74.42%   74.42%           
=======================================
  Files          57       57           
  Lines        5446     5446           
=======================================
  Hits         4053     4053           
  Misses       1022     1022           
  Partials      371      371           
Impacted Files Coverage Δ
v2/futures/order_service.go 59.04% <70.00%> (ø)
v2/margin_service.go 69.76% <85.00%> (ø)
v2/account_service.go 82.22% <100.00%> (ø)
v2/asset_detail_service.go 50.00% <100.00%> (ø)
v2/asset_dividend_service.go 82.85% <100.00%> (ø)
v2/client.go 85.04% <100.00%> (ø)
v2/delivery/account_service.go 69.23% <100.00%> (ø)
v2/delivery/client.go 83.10% <100.00%> (ø)
v2/delivery/exchange_info_service.go 86.95% <100.00%> (ø)
v2/delivery/kline_service.go 86.79% <100.00%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c85553...015a18c. Read the comment docs.

@adshao adshao merged commit 13013b3 into adshao:master Oct 7, 2021
@shoman4eg shoman4eg deleted the replace_http_methods branch October 7, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants