Fix error on getting exchange info with multiple symbols (issue #269) #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adshao
reviewed
Oct 7, 2021
| if len(symbols) == 0 { | ||
| s.symbols = "[]" | ||
| } else { | ||
| s.symbols = "[\"" + strings.Join(symbols, "\",\"") + "\"]" |
There was a problem hiding this comment.
Can we use json.Marshal instead of manually concatenating json strings?
There was a problem hiding this comment.
@adshao Thanks for responding. I would prefer concatenation for three reasons:
- It's the fastest way to get the needed string
json.Marshallreturns an error that should be either ignored or handled - unnecessary code and memory allocationjson.Marshallreturns bytes that should be further converted to string - unnecessary operation and memory allocation
There was a problem hiding this comment.
thanks @icamys , this looks good to me, could you please rebase the code since there is code conflict with the master branch.
adshao
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A solution similar to #267 , but includes tests.