Feature/subaccount service #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
==========================================
- Coverage 74.28% 73.82% -0.46%
==========================================
Files 58 59 +1
Lines 5502 5536 +34
==========================================
Hits 4087 4087
- Misses 1040 1074 +34
Partials 375 375
Continue to review full report at Codecov.
|
adshao
requested changes
Jul 27, 2021
v2/subaccount_service.go
Outdated
| } | ||
|
|
||
| // Test send test api to check if the request is valid | ||
| func (s *TransferToSubAccountService) Test(ctx context.Context, opts ...RequestOption) (err error) { |
There was a problem hiding this comment.
Hi @nandubatchu , I can't find the endpoint /test from binance API, is this an official API?
If you want to test the API, it's better to add unit test for it.
There was a problem hiding this comment.
Let me remove this /test method.
|
@adshao I have removed the test method |
adshao
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adshao Please validate if this can be merged.