Fix the bug of multiple symbol(#267) #269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cih2001
reviewed
Jun 4, 2021
v2/exchange_info_service.go
Outdated
Comment on lines
23
to
30
| symbols := "[" | ||
| for i, pair := range pairs { | ||
| if i != 0 { | ||
| symbols += "," | ||
| } | ||
| symbols += "\"" + pair + "\"" | ||
| } | ||
| symbols += "]" |
There was a problem hiding this comment.
Just formatted your code in a cleaner way. You also need to import strings package.
Suggested change
| symbols := "[" | |
| for i, pair := range pairs { | |
| if i != 0 { | |
| symbols += "," | |
| } | |
| symbols += "\"" + pair + "\"" | |
| } | |
| symbols += "]" | |
| if len(pairs) == 0 { | |
| s.symbols = "[]" | |
| } else { | |
| s.symbols = "[\"" + strings.Join(pairs, "\",\"") + "\"]" | |
| } | |
| return s |
|
@adshao any updates on this fix? |
icamys
approved these changes
Oct 5, 2021
icamys
reviewed
Oct 5, 2021
There was a problem hiding this comment.
The tests also should be updated. In the exchange_info_service_test.go the following line:
"symbols": symbols,should be:
"symbols": "[\"ETHBTC\",\"LTCBTC\"]",
adshao
pushed a commit
that referenced
this pull request
Oct 13, 2021
|
thanks @icamys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug (#267) and tried to fix it.
Correct request format:
curl -X GET "https://api.binance.com/api/v3/exchangeInfo?symbols=%5B%22BNBBTC%22,%22BTCUSDT%22%5D"
or
curl -g GET 'https://api.binance.com/api/v3/exchangeInfo?symbols=["BTCUSDT","BNBBTC"]'