Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isolatedSymbol parameter to GetMaxBorrowableService #231

Merged
merged 3 commits into from Dec 16, 2021

Conversation

beansgum
Copy link
Contributor

The isolatedSymbol parameter is required to get the max borrow amount of an isolated margin account.
See https://binance-docs.github.io/apidocs/spot/en/#query-max-borrow-user_data

The isolatedSymbol parameter is required to get max borrow amount
of an isolated margin account.
v2/margin_service.go Outdated Show resolved Hide resolved
Co-authored-by: Jérémy Pansier <jeremypansier@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2021

Codecov Report

Merging #231 (3a3cc4f) into master (8bc583a) will increase coverage by 2.49%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   74.78%   77.28%   +2.49%     
==========================================
  Files          55       59       +4     
  Lines        5077     7443    +2366     
==========================================
+ Hits         3797     5752    +1955     
- Misses        927     1245     +318     
- Partials      353      446      +93     
Impacted Files Coverage Δ
v2/margin_service.go 70.88% <14.28%> (+1.12%) ⬆️
v2/futures/order_service.go 64.30% <0.00%> (-6.18%) ⬇️
v2/futures/exchange_info_service.go 77.11% <0.00%> (-1.71%) ⬇️
v2/futures/websocket.go 4.83% <0.00%> (-1.69%) ⬇️
v2/delivery/websocket.go 4.83% <0.00%> (-1.69%) ⬇️
v2/websocket.go 4.83% <0.00%> (-1.55%) ⬇️
v2/delivery/exchange_info_service.go 85.41% <0.00%> (-1.54%) ⬇️
v2/trade_service.go 86.70% <0.00%> (-0.08%) ⬇️
v2/user_universal_transfer.go 88.23% <0.00%> (ø)
v2/subaccount_service.go 0.00% <0.00%> (ø)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bc583a...3a3cc4f. Read the comment docs.

Copy link
Contributor

@JeremyPansier JeremyPansier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@adshao adshao merged commit a6d7dc3 into adshao:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants