Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom file system support? #35

Open
nathanhammond opened this issue May 3, 2022 · 4 comments · May be fixed by #36
Open

Custom file system support? #35

nathanhammond opened this issue May 3, 2022 · 4 comments · May be fixed by #36

Comments

@nathanhammond
Copy link

Hello @adrg! Would you be interested in a pull request that enabled custom file system support? (e.g. afero)
@nathanhammond nathanhammond mentioned this issue May 3, 2022
Merged
@adrg
Copy link
Owner

adrg commented May 3, 2022

Hi @nathanhammond. Thank you for your interest in the library. Sure, that would be great.

I assume the PR would add an interface which defines all permitted file system operations and a 'local fs' implementation of that interface, which would be the default?

@nathanhammond
Copy link
Author

If that's the implementation that you feel like makes the most sense, then, yes!

I'll get you a draft PR for your consideration up shortly.

@adrg
Copy link
Owner

adrg commented May 3, 2022

Sorry, I was just wondering if you were thinking of something along those lines 😄.
I'm not sure if it's the best way to do it, just my initial thoughts on this.

@xescugc
Copy link

xescugc commented May 18, 2022

@nathanhammond are you working on it? Because I'm also interested in it hehe.

@xescugc xescugc linked a pull request May 18, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xdg: Add the hability to initialize a new BaseDir with different FS behind xescugc/xdg
3 participants
@nathanhammond @xescugc @adrg