Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Known Folders support on Windows #27

Merged
merged 47 commits into from Oct 27, 2021
Merged

Add Known Folders support on Windows #27

merged 47 commits into from Oct 27, 2021

Conversation

adrg
Copy link
Owner

@adrg adrg commented Oct 24, 2021

  • Add Known Folders support on Windows
  • Internal package refactor
  • Improve test coverage

Addresses #24.

@adrg adrg marked this pull request as draft October 24, 2021 11:01
@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #27 (2928c45) into master (addede4) will increase coverage by 3.55%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #27      +/-   ##
===========================================
+ Coverage   96.44%   100.00%   +3.55%     
===========================================
  Files           8         8              
  Lines         281       381     +100     
===========================================
+ Hits          271       381     +110     
+ Misses         10         0      -10     
Impacted Files Coverage Δ
base_dirs.go 100.00% <100.00%> (ø)
internal/pathutil/pathutil.go 100.00% <100.00%> (ø)
internal/pathutil/pathutil_unix.go 100.00% <100.00%> (ø)
internal/pathutil/pathutil_windows.go 100.00% <100.00%> (ø)
paths_darwin.go 100.00% <100.00%> (ø)
paths_unix.go 100.00% <100.00%> (ø)
paths_windows.go 100.00% <100.00%> (ø)
xdg.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update addede4...2928c45. Read the comment docs.

@adrg adrg marked this pull request as ready for review October 25, 2021 15:00
@adrg adrg merged commit 210f365 into master Oct 27, 2021
@adrg adrg deleted the windows-known-folders branch October 27, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant