Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hoek security issue (downstream dependency) #187

Closed
gorner opened this issue Jul 17, 2018 · 3 comments · Fixed by #189
Closed

hoek security issue (downstream dependency) #187

gorner opened this issue Jul 17, 2018 · 3 comments · Fixed by #189

Comments

@gorner
Copy link
Contributor

gorner commented Jul 17, 2018

npm audit yields the following issue which cannot be automatically resolved:

┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Moderate      │ Prototype pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ hoek                                                         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ > 4.2.0 < 5.0.0 || >= 5.0.3                                  │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ [redacted SHA]                                               │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ [redacted SHA]                                               │
│               │ > ember-cli-sass > broccoli-sass-source-maps > node-sass >   │
│               │ node-gyp > request > hawk > boom > hoek                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/566                       │
└───────────────┴──────────────────────────────────────────────────────────────┘

Fix is presumably dependent on nodejs/node-gyp#1492 - this is just to track.

@Frozenfire92
Copy link

👍 Github is starting to warn about this

I traced it here via

hawk
node-gyp
node-sass
broccoli-sass-source-maps
ember-cli-sass

image

@Frozenfire92
Copy link

I'm happy to work on this with some guidance, but I think this is in need of a bump

@gorner
Copy link
Contributor Author

gorner commented Sep 12, 2018

@Frozenfire92 my PR #189 should cover this, if/when it's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants