Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong documentation for database driver config #174

Closed
ricardoaranha96 opened this issue Jul 13, 2022 · 1 comment
Closed

Wrong documentation for database driver config #174

ricardoaranha96 opened this issue Jul 13, 2022 · 1 comment
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@ricardoaranha96
Copy link

Package version

5.8.4

Describe the bug

Link of documentation: https://docs.adonisjs.com/guides/database/introduction#drivers-config

The documentation guides us to install the package mysql2 but in the config example the client used is mysql. After I changed it to mysql2 the config started to work.

Also, the code generated by node ace configure @adonisjs/lucid generates a file with a comment that instructs to install mysql instead of mysql2.

Reproduction repo

No response

@RomainLanz RomainLanz added bug Something isn't working documentation Improvements or additions to documentation labels Oct 21, 2022
RomainLanz added a commit that referenced this issue Oct 21, 2022
@RomainLanz RomainLanz self-assigned this Oct 21, 2022
@RomainLanz
Copy link
Member

RomainLanz commented Oct 21, 2022

Hey @ricardoaranha96! 👋🏻

I have fixed the missing documentation, and this PR adonisjs/lucid#871 did the generated files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants