Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: new ci pipeline #878

Merged
merged 6 commits into from Sep 9, 2022
Merged

Conversation

Julien-R44
Copy link
Member

Hey

So let me recap:

  • Now we don't need a "lucid" image to run the tests. To run them locally, we just launch the database container and run the tests.
  • In CI, we use the container services of GH Actions instead of launching the containers manually, which seems to be faster
  • Here is the new pipeline, first we install the packages, then we execute lint and ypecheck in parallel, then to finish all the DB tests in parallel :
    image
    We now have a much higher coverage test, with node 14, 16, and 18 being tested. Also several versions of each database are tested. And with this, we have an CI duration of ~7 minutes, against 25 minutes before
  • Added a small script to run local tests more easily. Usage: ./scripts/run-test.sh sqlite or ./scripts/run-test.sh pg for exemple

Close #877

@Julien-R44
Copy link
Member Author

I think there is a problem with this test:
image

From time to time it fails without any reason. I'll just restart the CI for now

@targos targos self-requested a review September 6, 2022 10:46
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
@Julien-R44
Copy link
Member Author

Julien-R44 commented Sep 6, 2022

It's even faster now, without the useless install job and the lint/typecheck dependencies 🚀
Thanks a lot @targos !!

Well however, we still have this damn test that fails for no reason

scripts/run-tests.sh Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
Julien-R44 and others added 2 commits September 6, 2022 14:33
Co-authored-by: Michaël Zasso <targos@protonmail.com>
@targos
Copy link
Member

targos commented Sep 6, 2022

Looks great!

@Julien-R44
Copy link
Member Author

Awesome! Thanks again for the review, I missed a lot of mistakes 🥲

@thetutlage thetutlage merged commit 5a29d97 into adonisjs:develop Sep 9, 2022
@thetutlage
Copy link
Member

Thanks a ton @Julien-R44 and @targos for this 👍

@Julien-R44 Julien-R44 deleted the develop-origin branch September 9, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split test workflow into a matrix
3 participants