New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: new ci pipeline #878
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
reviewed
Sep 6, 2022
It's even faster now, without the useless install job and the lint/typecheck dependencies 🚀 Well however, we still have this damn test that fails for no reason |
targos
reviewed
Sep 6, 2022
targos
reviewed
Sep 6, 2022
Looks great! |
Awesome! Thanks again for the review, I missed a lot of mistakes 🥲 |
Thanks a ton @Julien-R44 and @targos for this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey
So let me recap:
We now have a much higher coverage test, with node 14, 16, and 18 being tested. Also several versions of each database are tested. And with this, we have an CI duration of ~7 minutes, against 25 minutes before
./scripts/run-test.sh sqlite
or./scripts/run-test.sh pg
for exempleClose #877