Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update mysql client to mysql2 #871

Merged
merged 1 commit into from Aug 26, 2022

Conversation

McSneaky
Copy link
Contributor

Proposed changes

Updating to mysql2 allows to use MySQL 8 and above. There's been issue opened in mysql repo, but seems like it's stale mysqljs/mysql#1959

mysql2 is API compatible with mysql so there really shouldn't be any breaking changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes (Used GH online edit, didn't run tests)
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate) - Update to mysql2 v5-docs#179

Further comments

@McSneaky McSneaky mentioned this pull request Aug 21, 2022
6 tasks
@thetutlage thetutlage merged commit 4d7498d into adonisjs:develop Aug 26, 2022
@thetutlage
Copy link
Member

Danke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants