Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(seeds): new environment config #851

Merged
merged 4 commits into from Aug 26, 2022
Merged

test(seeds): new environment config #851

merged 4 commits into from Aug 26, 2022

Conversation

RomainLanz
Copy link
Member

Hey there! 馃憢馃徎

This PR adds the option environment to the Seeder class.
This allows us to configure what environment our seeder should run more precisely.

The current developmentOnly setting is too restrictive.

@RomainLanz RomainLanz added the Type: Enhancement Improving an existing feature label Jun 8, 2022
@thetutlage
Copy link
Member

Can we also deprecate the developmentOnly flag with a runtime warning and also using @deprecated docblock for TypeScript?

@RomainLanz
Copy link
Member Author

I have updated the code to add the deprecation warning.
However, I am unsure about the runtime warning since the flag is defined in BaseSeeder.

@RomainLanz
Copy link
Member Author

Small bump 馃構

@thetutlage
Copy link
Member

Can we also update the docs to reflect the usage of environment? https://docs.adonisjs.com/guides/database/seeders#development-only-seeders

@thetutlage thetutlage merged commit 11ae8b6 into develop Aug 26, 2022
@RomainLanz RomainLanz deleted the feat/seeder-env branch November 1, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants