[Bug]: TypeError: Cannot read properties of undefined (reading 'selectionRoot') in Menu.handlePointerBasedSelection

[spdev3000]

Code of conduct

• I agree to follow this project's code of conduct.

Impacted component(s)

Menu

Expected behavior

When using non-menu-item components as submenu clicking those components shouldn't trigger TypeError

Actual behavior

Using arbitrary components as submenu items and clicking them produces the TypeError:
Cannot read properties of undefined (reading 'selectionRoot') in Menu.handlePointerBasedSelection

Screenshots

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

1. Go to '...'
2. Click on '....'
3. Scroll to '....'
4. Check console
5. See error

Sample code that illustrates the problem

This might be fixed by adding ? after menuData, see:

 target?.menuData?.selectionRoot === this &&

in

spectrum-web-components/packages/menu/src/Menu.ts

Line 391 in d38bf04

target?.menuData.selectionRoot === this &&

Logs taken while reproducing problem

No response

[Westbrook]

I'm surprised that without a Menu Item that this code is finding a trigger. Can you share what the trigger is so we can understand how it is both el.getAttribute('role') === this.childRole and el.menuData === undefined?

[spdev3000]

  handlePointerBasedSelection(event) {
    const path = event.composedPath();
    const target = path.find((el) => {
      if (!(el instanceof Element)) {
        return false;
      }
      console.log("MENU SWC: ", el);
      return el.getAttribute("role") === this.childRole;
    });

prints out:

<li class="spectrum-Menu-item" tabindex="0" role="menuitem"><span class="spectrum-Menu-itemLabel"><span>Edit version info</span></span></li>

and leads to:

    TypeError: Cannot read properties of undefined (reading 'selectionRoot')
    at Menu.handlePointerBasedSelection (chunk-SCU35XXF.js?v=c2a8ef54:347:59)
    at Menu.handlePointerup (chunk-SCU35XXF.js?v=c2a8ef54:321:10)
    at Menu.nrWrapper (chunk-DTJESBZO.js?v=c2a8ef54:71:21)

[najikahalsema]

We can add this, but we should make sure we add tests for this case.