Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Samsung Galaxy S23 Ultra Not Considered a Small/Mobile Devoce #4262

Open
1 task done
croberts5 opened this issue Apr 11, 2024 · 2 comments
Open
1 task done
Labels
bug Something isn't working Mobile triage An issue needing triage

Comments

@croberts5
Copy link

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-action-menu

Expected behavior

When opening sp-action-menu on a mobile device (any iPhone for example), the menu items are wrapped in sp-tray.
When opening an action menu in a Samsung Galaxy S23 Ultra, the menu items should render in a tray.

Actual behavior

When the device is a Samsung Galaxy S23 Ultra, the menu renders in a popover like a tablet or desktop device.

Screenshots

No response

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to SWC docs for Action menu on a Samsung Galaxy S23 Ultra device
  2. Click on '.... More Actions' button in the "Sizes" section
  3. Assert the menu items are not rendered in a tray

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

@croberts5 croberts5 added bug Something isn't working triage An issue needing triage labels Apr 11, 2024
@Westbrook
Copy link
Contributor

Can you share whether or not this decide meets the following criteria of "mobile" for our context:

  • (max-width: 700px) and (hover: none) and (pointer: coarse)
    • width of less than 700px
    • does not include support for "hover"
    • has a coarse input device (some Android devices have a stylus which invalidates this check)
  • (max-height: 700px) and (hover: none) and (pointer: coarse)
    • height of less than 700px
    • does not include support for "hover"
    • has a coarse input device (some Android devices have a stylus which invalidates this check)

@najikahalsema
Copy link
Collaborator

@croberts5 Have you been able to see if the device meets the criteria?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Mobile triage An issue needing triage
Projects
None yet
Development

No branches or pull requests

3 participants