Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

When --update-package is executed, output the hash of the parameters #196

Open
dominique-pfister opened this issue Dec 17, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@dominique-pfister
Copy link
Contributor

This feature would nicely integrate with https://github.com/adobe/helix-param-checker

That runtime action checks the consistency of package secrets using a SHA256. In order to not have that action's monitor report a failure with the expected hash first before being able to update that hash, it would be nice if the builder would output the expected hash when running --update-package.

@dominique-pfister dominique-pfister added the enhancement New feature or request label Dec 17, 2020
@dominique-pfister dominique-pfister self-assigned this Dec 17, 2020
@trieloff
Copy link
Contributor

Do we need the same feature in helix-deploy or can it wait and we only implement it there?

@dominique-pfister
Copy link
Contributor Author

I think it can wait: this feature would be nice to have when executing

$ wsk-builder --no-build --no-hints --update-package

when some secrets in the package params file changed.

@tripodsan
Copy link
Collaborator

I think we can add it now, and then port it to helix-deploy once finished.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants