Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust defaults to include *.js in build #328

Closed
trieloff opened this issue Nov 16, 2018 · 6 comments · Fixed by #325
Closed

Adjust defaults to include *.js in build #328

trieloff opened this issue Nov 16, 2018 · 6 comments · Fixed by #325
Assignees
@tripodsan
Labels
enhancement New feature or request

Comments

@trieloff
Copy link
Contributor

@rofe observed that src/**/*.js is not included in the default sources for hlx up and hlx build, this should get adjusted to support pure-JS actions.
@trieloff trieloff added enhancement New feature or request good first issue Good for newcomers labels Nov 16, 2018
@tripodsan
Copy link
Contributor

please provide example. what are pure-js actions?

@tripodsan
Copy link
Contributor

I think this is a bit tricky, since it must not match the ...pre.js.

@tripodsan tripodsan removed the good first issue Good for newcomers label Nov 18, 2018
@tripodsan
Copy link
Contributor

i'll cover this with #23

@tripodsan tripodsan self-assigned this Nov 19, 2018
@rofe
Copy link
Contributor

rofe commented Nov 19, 2018

please provide example. what are pure-js actions?

I tried with a bla_html.js

@tripodsan tripodsan mentioned this issue Nov 19, 2018
Merged
@trieloff
Copy link
Contributor Author

A Pure-JS action is an action that has a JS file at the heart (once) of its pipeline. Instead of having the JS compiled from HTL, JST, JSX, or any other templating language, a developer has written their own html.js, xml.js, or json.js to emit something that is more structured than the typical HTML output.

@tripodsan tripodsan mentioned this issue Nov 19, 2018
Closed
@tripodsan
Copy link
Contributor

ok, so basically a pre.js without the pre :-)

currently, we don't to any pipeline wrapping to .js functions in parcel. I created a new issue: #334

tripodsan added a commit that referenced this issue Nov 21, 2018
@tripodsan
Improve startup time (#325)
434641b 
- Pure scripts don't have source maps (#329)
- Adjust defaults to include *.js in build (#328)
- use default adobeio-runtime provided action type to reduce startup time (#308)
- Bundle dependencies that are not container-provided (#23)

(fixes #23, fixes #308, fixes #328, fixes #329)
@gr00nd gr00nd mentioned this issue Feb 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tripodsan tripodsan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve startup time adobe/helix-cli
3 participants
@trieloff @tripodsan @rofe