Rukenshia/trello Merge #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-start-date * https://github.com/Rukenshia/trello: Add start/due test to AddCardToList Add tests for card start/due on CreateCard Add "start" field to trello.Card Use rate package for rate limiting Update go.mod Expose time.Ticker for manual cleanup
This type will eventually replace all occurrences of mockResponse, mockDynamicResponse. For now its used only on card_test.go and eliminates only the mockResponseWithRequestValidator().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes PR #88 (adding the
Startfield to Card) as well as the Client.Cleanup() method for cleaning up the rate limiting ticker (from Rukenshia/trello).It also introduces a new method for testing mocks that allows request assertions (see:
MockResponder)