Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About assert string contains #9

Open
1 of 3 tasks
peter279k opened this issue Mar 25, 2019 · 4 comments
Open
1 of 3 tasks

About assert string contains #9

peter279k opened this issue Mar 25, 2019 · 4 comments

Comments

@peter279k
Copy link
Collaborator

Introduction

It's about the feature request about asserting string contains.

  • Bug/Issue
  • Feature request
  • General stuff

Description

Consider the following points:

  • Add assertIterableContains() and assertStringContains() in PHPUnit 7.5
  • Deprecate (soft) assertContains() in PHPUnit 7.5
  • Deprecate (hard) assertContains() in PHPUnit 8.0

Should we implement all these assertions (including deprecated assertions)?

The detailed issues are as follows:

@adhocore
Copy link
Owner

sorry for late. i think we should not implement deprecated assertions. they are deprecated for some valid reasons. we may however add something new? 😎

@peter279k
Copy link
Collaborator Author

What about Add assertIterableContains() and assertStringContains() in PHPUnit 7.5?

These assertions are new and it's available in PHPUnit 7.5.

Repository owner deleted a comment from zhouxing5311 Feb 21, 2024
@peter279k
Copy link
Collaborator Author

@adhocore, I've removed the comment because it contains the phishing websites.

@zhouxing5311
Copy link

zhouxing5311 commented Feb 21, 2024

@adhocore, I've removed the comment because it contains the phishing websites.

sorry for that, i accidentally clicked on a phishing link and I have removed the verification for it.

if you recevie an email which told you offer you a job and give you a link to click, it is a phishing link, do not click an delete that email.
image

Repository owner locked and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants