Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"id" field of PublicKeyCredentialDescriptor is wrongly typed #5

Open
Ponjimon opened this issue Nov 21, 2020 · 1 comment
Open

"id" field of PublicKeyCredentialDescriptor is wrongly typed #5

Ponjimon opened this issue Nov 21, 2020 · 1 comment

Comments

@Ponjimon
Copy link

Ponjimon commented Nov 21, 2020

It should be of type BufferSource. I would suggest just removing it from the code alltogether since PublicKeyCredentialDescriptor is a global type anyway and is already included in TypeScript in lib.dom.d.ts

ref

@adenvt
Copy link
Owner

adenvt commented Nov 23, 2020

The problem is communication from server-side to client-side, all buffer decoded into base64 format. That why "id" in there was string not buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants