Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SX Design: Button left with hover state on iOS #2935

Open
tbergquist-godaddy opened this issue Aug 11, 2021 · 3 comments
Open

SX Design: Button left with hover state on iOS #2935

tbergquist-godaddy opened this issue Aug 11, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@tbergquist-godaddy
Copy link
Contributor

tbergquist-godaddy commented Aug 11, 2021

When the button is clicked on iOS, the button is left with the hover style until it loses focus.

Screenshot 2021-08-11 at 22 17 57

See as a possible solution:

@mrtnzlml mrtnzlml changed the title sx-design: Button left with hover state on iOS SX Design: Button left with hover state on iOS Aug 12, 2021
@mrtnzlml mrtnzlml added this to To do in SX, SX Design via automation Aug 12, 2021
@mrtnzlml mrtnzlml added the bug Something isn't working label Aug 12, 2021
@mrtnzlml
Copy link
Member

@tbergq Do you think that every :hover style should be wrapped in the media query like in the following example?

@media (hover: hover) {
  button:hover {
    border: 3px solid green;
  }
}

Is there any reason why we should not do it (automatically)?

@tbergquist-godaddy
Copy link
Contributor Author

@tbergq Do you think that every :hover style should be wrapped in the media query like in the following example?

@media (hover: hover) {
  button:hover {
    border: 3px solid green;
  }
}

Is there any reason why we should not do it (automatically)?

No, I can't think of any reason not to do this automatically 😊

@mrtnzlml
Copy link
Member

OK, thanks! I have it on the roadmap: #996

First, I need to do some changes to the SX core though to be able to improve and fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants