flowtype/no-internal-flow-type eslint error for flow-typed

[jcolakk]

Hi 👋 in our repo we started to get flowtype/no-internal-flow-type eslint error for package types in flow-typed. We are using @adeira/eslint-config in our repo.
How do you recommend handling this?

1. Ignore flow-typed in .eslintignore
2. Change it to not use internal flow type, e.g from React$Element to ReactElement, but this causes flow error instead Cannot resolve name ReactElement

[tbergquist-godaddy]

import * as React from 'react';

let Component: React.Element<{children: React.Node}>;

[mrtnzlml]

@tbergq Not sure it's a good idea to modify 3rd party flow-typed definitions like this. Maybe rather update the upstream repo? 🤔

[mrtnzlml]

It's strange that you started getting some new errors since the only thing which changed was the rule name, see: e624e72 (Maybe you had adeira/no-internal-flow-type rule ignored? Search for it in your codebase.)

Anyway, in case of this repository, we are not running lints for flow-typed directory because the assumption is that the code is OK and not edited manually very often since it's mostly 3rd party.

I'd recommended you to ignore it as well (or at least flow-typed/npm).

[tbergquist-godaddy]

Sorry, I missed that this was in flow-typed 🙈

[jcolakk]

Ah, yes, we had it disabled for flow-typed already. That makes sense, I also didn't want to update the 3rd party types.
Thanks guys 👍

[mrtnzlml]

Sorry for the breaking change. I didn't realize it could have such consequences.