Fix tests on Windows. #330
Merged
+7
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could probably abstract the cmd code but maybe later after the tests are green. |
|
#326 needs to be smaller somehow :/ Maybe try to move some patches to master like the linting changes and then rebase that branch. |
bezoerb
pushed a commit
that referenced
this pull request
Oct 28, 2018
Requires #330 to be merged first.
XhmikosR
added a commit
that referenced
this pull request
Jul 31, 2019
/CC @addyosmani @bezoerb Locally on Windows I get `103 passing (1m)`
XhmikosR
added a commit
that referenced
this pull request
Jul 31, 2019
/CC @addyosmani @bezoerb Locally on Windows I get `103 passing (1m)`
XhmikosR
added a commit
that referenced
this pull request
Jul 31, 2019
/CC @addyosmani @bezoerb Locally on Windows I get `103 passing (1m)`
XhmikosR
added a commit
that referenced
this pull request
Aug 6, 2019
/CC @addyosmani @bezoerb Locally on Windows I get `103 passing (1m)`
XhmikosR
added a commit
that referenced
this pull request
Aug 6, 2019
/CC @addyosmani @bezoerb Locally on Windows I get `103 passing (1m)`
XhmikosR
added a commit
that referenced
this pull request
Aug 6, 2019
/CC @addyosmani @bezoerb Locally on Windows I get `103 passing (1m)`
XhmikosR
added a commit
that referenced
this pull request
Aug 7, 2019
XhmikosR
added a commit
that referenced
this pull request
Aug 7, 2019
XhmikosR
added a commit
that referenced
this pull request
Aug 8, 2019
XhmikosR
added a commit
that referenced
this pull request
Aug 12, 2019
XhmikosR
added a commit
that referenced
this pull request
Aug 13, 2019
XhmikosR
added a commit
that referenced
this pull request
Aug 13, 2019
XhmikosR
added a commit
that referenced
this pull request
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/CC @addyosmani @bezoerb
Locally on Windows I get
103 passing (1m)