Downgrade System.Memory to fix buffer version issue #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I can confirm this PR fixes bug #591. |
schlotter
reviewed
Apr 26, 2021
| @@ -35,7 +35,8 @@ | |||
| </ItemGroup> | |||
| <ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' "> | |||
| <PackageReference Include="System.Text.Encoding.CodePages" Version="5.0.0" /> | |||
| <PackageReference Include="System.Memory" Version="4.5.4" /> | |||
| <PackageReference Include="System.Memory" Version="4.5.3" /> | |||
| <PackageReference Include="System.Buffers" Version="4.4.0" /> | |||
There was a problem hiding this comment.
Maybe a comment could be added that the System.Buffers package reference can be removed as soon as dotnet/runtime#1830 is fixed?
schlotter
approved these changes
Apr 26, 2021
|
Hi @adamhathcock! This looks good to me. Do you plan to merge? Best regards, |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.