Not so elegant perhaps for checking 7z encryption #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks elegant enough to me. I don't know enough about the 7Zip spec off hand to know if that's correct though. |
|
Digging some more I don't think it is too far off p7zip discussion on sourceforge More complete might be to just detect that it starts with 06 xx xx xx From 7zip DOC/Methods.txt F0 - Ciphers without hashing algo F1 - Combine Ciphers |
adamhathcock
approved these changes
Feb 16, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#539
#521
Could this be a solution?