Improve how missing parts are handled #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamhathcock
approved these changes
Feb 14, 2021
|
I'm pleased you like the option, however I didn't expect you to merge it so quick as the tests are failing (I'd never actually run them myself as the changes were so small). One is an easy fix, just changing the expected exception, the others require a good bit more consideration as I think they are making some assumptions which aren't always accurate. |
|
Actually the fix was better split detection by default: a51b563 I knew things were failing but I like merging in good ideas. If you're not done, consider using the Draft PR feature. Can discuss without worrying about a quick merge if you're not ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been doing some work involving processing incomplete RAR files and file sets, and I had to make a few tweaks to make SharpCompress ok with trying to read the partial data and figured they useful enough to share.