Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use WriteToDirectory method to RarArchiveEntry,throw NotImplementedException,but uncompress success,is it bug ? #796

Open
zhangqi-ulua opened this issue Jan 3, 2024 · 4 comments

Comments

@zhangqi-ulua
Copy link

ExtractionOptions extractionOptions = new ExtractionOptions();
extractionOptions.ExtractFullPath = true;
extractionOptions.Overwrite = true;
extractionOptions.PreserveAttributes = true;
extractionOptions.PreserveFileTime = true;

RarArchive archive = ArchiveFactory.Open(@“D:\test.rar”);
foreach (IArchiveEntry oneEntry in archive.Entries)
{
if(oneEntry.Key == "1.jpg")
oneEntry.WriteToDirectory(@"D:\result", extractionOptions);
}

throw System.NotImplementedException:“The method or operation is not implemented.”

but the file is really uncompress success.I think is BUG

@zhangqi-ulua
Copy link
Author

Also I found any rar file use WriteToFile is same (throw System.NotImplementedException:“The method or operation is not implemented.”but the file is really uncompress success)

@Erior
Copy link
Contributor

Erior commented Jan 4, 2024

if you have the test file available we can have a look on why it gives not implemented. RAR support is not complete but mostly works.

@zhangqi-ulua
Copy link
Author

The reason I didn't upload a RAR attachment earlier is that for any RAR file, attempting to execute WriteToDirectory or WriteToFile on any of the entries throws a NotImplementedException, even though the files can be extracted normally. If you really need me to upload one, I can upload just any file(Since GitHub does not support uploading files in RAR format, I have placed the RAR test file inside a ZIP file for uploading.
test.zip
).

Additionally, I've encountered another issue. For any 7z file that contains a large number of files, a full extraction of the 7z file might take around 10 seconds, but if I use a foreach loop to execute WriteToFile for each entry, the total time taken is more than tenfold.

@Erior
Copy link
Contributor

Erior commented Jan 5, 2024

The ExtractOptions above should work with the pull request I made.

I can add that NTFS ACL and UNIX owner handling is not implemented for RAR files, but does not trigger an exception

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants