Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReaderFactory not iterating over big entries #795

Open
jbrockerville opened this issue Jan 2, 2024 · 2 comments
Open

ReaderFactory not iterating over big entries #795

jbrockerville opened this issue Jan 2, 2024 · 2 comments
Labels
bug up for grabs

Comments

@jbrockerville
Copy link

I've encountered an issue with the ReaderFactory and ZIP archives with "big" entries. If an archive has a sufficiently big enough entry, the reader fails to iterate over all the entries. No error. Just no next entry and drops out of the loop. The ArchiveFactory seems fine. Please see the attached code for generating the archive ("data/data.py") and reproducing the bug. Here is the output I get:

Entries via ReaderFactory...
  bin1.bin
Entries via ArchiveFactory...
  bin1.bin
  a.txt
  c.txt

BigArchive.zip
@Erior Erior mentioned this issue Jan 4, 2024
Merged
@adamhathcock
Copy link
Owner

Maybe #799 will address

@DannyBoyk
Copy link
Contributor

Latest SharpCompress code produces identical results for ReaderFactory and ArchiveFactory, so it appears this can be closed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug up for grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adamhathcock @DannyBoyk @jbrockerville