New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flush should probably not throw NotSupportedException #771

Open

carlreinke opened this issue Sep 26, 2023 · 1 comment

Labels

bug up for grabs

carlreinke commented Sep 26, 2023

According to the Stream.Flush docs:

In a class derived from Stream that doesn't support writing, Flush is typically implemented as an empty method to ensure full compatibility with other Stream types since it's valid to flush a read-only stream.

sharpcompress/src/SharpCompress/Compressors/LZMA/DecoderStream.cs

Line 17 in 66c9263

public override void Flush() => throw new NotSupportedException();

Owner

adamhathcock commented Sep 27, 2023

Good catch and good PR

adamhathcock added bug up for grabs labels

Erior mentioned this issue

Issue 771, remove throw on flush for readonly streams #801

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment