Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create directory when overwrite option is set #693

Open
rhuesken opened this issue Aug 24, 2022 · 2 comments
Open

Create directory when overwrite option is set #693

rhuesken opened this issue Aug 24, 2022 · 2 comments

Comments

@rhuesken
Copy link

In 0.32.2, I found that I need to create the "destination" directory first, in order for this call to succeed:

                    reader.WriteEntryToDirectory(destination, new ExtractionOptions()
                    {
                        ExtractFullPath = true,
                        Overwrite = overWrite
                    });

This was working fine with 0.28.2, which creates the "destination" directory if it does not exists. Is this the same issue as #614 ? I have the impression it should have been fixed in 0.29.0... Is that correct?

@Erior
Copy link
Contributor

Erior commented Aug 25, 2022

From what I can see, the 0.29 change checks that you have already created it before calling WriteEntryToDirectory

@adamhathcock
Copy link
Owner

Maybe overwrite should always create the directory. Can't recall the reason for change at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants